-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚗️[RUM-2889] Bootstrap custom vital APIs #2591
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2591 +/- ##
==========================================
- Coverage 92.78% 92.78% -0.01%
==========================================
Files 235 236 +1
Lines 6794 6820 +26
Branches 1489 1492 +3
==========================================
+ Hits 6304 6328 +24
- Misses 490 492 +2 ☔ View full report in Codecov by Sentry. |
bcaudan
force-pushed
the
bcaudan/custom-vital
branch
from
February 7, 2024 13:17
671a008
to
21c2703
Compare
bcaudan
force-pushed
the
bcaudan/custom-vital
branch
from
February 7, 2024 13:59
21c2703
to
402ef40
Compare
N-Boutaib
reviewed
Feb 8, 2024
N-Boutaib
approved these changes
Feb 9, 2024
amortemousque
approved these changes
Feb 9, 2024
BenoitZugmeyer
approved these changes
Feb 12, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Initial PR to provide APIs to track custom duration as vital events
Changes
Behind
custom_vitals
flag, add APIs:and support the new event type across the code base:
Note: First PR with the simplest API, more features in following PRs (customer context, rate limiter, ...)
Testing
I have gone over the contributing documentation.