Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚗️[RUM-2889] Bootstrap custom vital APIs #2591

Merged
merged 8 commits into from
Feb 12, 2024
Merged

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Feb 5, 2024

Motivation

Initial PR to provide APIs to track custom duration as vital events

Changes

Behind custom_vitals flag, add APIs:

DD_RUM.startDurationVital('foo')
// do some stuff
DD_RUM.stopDurationVital('foo')

and support the new event type across the code base:

Screenshot 2024-02-05 at 15 17 25

Note: First PR with the simplest API, more features in following PRs (customer context, rate limiter, ...)

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2f0fbbc) 92.78% compared to head (5752874) 92.78%.

Files Patch % Lines
packages/rum-core/test/fixtures.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2591      +/-   ##
==========================================
- Coverage   92.78%   92.78%   -0.01%     
==========================================
  Files         235      236       +1     
  Lines        6794     6820      +26     
  Branches     1489     1492       +3     
==========================================
+ Hits         6304     6328      +24     
- Misses        490      492       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bcaudan bcaudan force-pushed the bcaudan/custom-vital branch from 671a008 to 21c2703 Compare February 7, 2024 13:17
@bcaudan bcaudan force-pushed the bcaudan/custom-vital branch from 21c2703 to 402ef40 Compare February 7, 2024 13:59
@bcaudan bcaudan marked this pull request as ready for review February 7, 2024 14:14
@bcaudan bcaudan requested a review from a team as a code owner February 7, 2024 14:14
@N-Boutaib N-Boutaib requested a review from a team February 8, 2024 09:20
@bcaudan bcaudan merged commit baa95d3 into main Feb 12, 2024
17 checks passed
@bcaudan bcaudan deleted the bcaudan/custom-vital branch February 12, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants