-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [RUM-2902] Add error causes to context when logging an error #2602
✨ [RUM-2902] Add error causes to context when logging an error #2602
Conversation
PR looks good, but I think we should collect error causes for other errors collected by the Logs SDK:
I think that's it? Maybe a function to format a rawError into log |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2602 +/- ##
=======================================
Coverage 92.78% 92.78%
=======================================
Files 235 235
Lines 6794 6795 +1
Branches 1489 1490 +1
=======================================
+ Hits 6304 6305 +1
Misses 490 490 ☔ View full report in Codecov by Sentry. |
💭 thought: It's not directly related to the PR but looking at how we collect errors in Logs it seems we have some discrepancies:
It could be nice to have a more centralize ways to format Error. You could introduce something in this PR like mentioned by @BenoitZugmeyer (cf comment) or maybe in a following PR :) |
/merge |
🚂 MergeQueue Pull request added to the queue. This build is going to start soon! (estimated merge in less than 33m) Use |
Motivation
This PR addresses this issue in order to add an error's causes when logging it.
Changes
Add flattened error causes to the error's context when logging it.
Testing
I have gone over the contributing documentation.