Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨[RUM-3151] Report bundle sizes to logs #2605

Merged
merged 21 commits into from
Feb 15, 2024
Merged

Conversation

RomanGaignault
Copy link
Contributor

Motivation

To send bundle sizes to logs and check the evolution with dashboard.

Changes

Added a script to retrieve git commit Id, version, branch and bundle size then send them to logs with fetch request.
image

Testing

  • Local
  • Staging
  • CI
  • Unit
  • End to end

I have gone over the contributing documentation.

@RomanGaignault RomanGaignault changed the title Roman/send bundle sizes ✨[RUM-3151] Report bundle sizes to logs Feb 12, 2024
@RomanGaignault
Copy link
Contributor Author

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Feb 12, 2024

🚂 Branch Integration: starting soon, merge in < 9m

Commit 8b13c6c525 will soon be integrated into staging-07.

This build is going to start soon! (estimated merge in less than 9m)

Use /to-staging -c to cancel this operation!

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Feb 12, 2024

⚠️ Branch Integration: This commit was already integrated

Commit 8b13c6c525 had already been merged into staging-07

If you need support, contact us on Slack #ci-interfaces!

@RomanGaignault RomanGaignault marked this pull request as ready for review February 12, 2024 14:51
@RomanGaignault RomanGaignault requested a review from a team as a code owner February 12, 2024 14:51
scripts/export-bundles-sizes.js Outdated Show resolved Hide resolved
scripts/export-bundles-sizes.js Outdated Show resolved Hide resolved
scripts/export-bundles-sizes.js Outdated Show resolved Hide resolved
scripts/export-bundles-sizes.js Outdated Show resolved Hide resolved
scripts/export-bundles-sizes.js Outdated Show resolved Hide resolved
@BenoitZugmeyer BenoitZugmeyer requested a review from a team February 13, 2024 13:22
@RomanGaignault
Copy link
Contributor Author

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Feb 13, 2024

🚂 Branch Integration: starting soon, merge in < 9m

Commit bc7f0c6290 will soon be integrated into staging-07.

This build is going to start soon! (estimated merge in less than 9m)

Use /to-staging -c to cancel this operation!

dd-mergequeue bot added a commit that referenced this pull request Feb 13, 2024
Co-authored-by: roman.gaignault <roman.gaignault@datadoghq.com>
@dd-devflow
Copy link
Contributor

dd-devflow bot commented Feb 13, 2024

🚂 Branch Integration: This commit was successfully integrated

Commit bc7f0c6290 has been merged into staging-07 in merge commit 335764e57b.

Check out the triggered pipeline on Gitlab 🦊

Copy link
Contributor

@N-Boutaib N-Boutaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one 🎉

.gitignore Outdated Show resolved Hide resolved
.gitlab-ci.yml Show resolved Hide resolved
scripts/export-bundles-sizes.js Outdated Show resolved Hide resolved
scripts/export-bundles-sizes.js Show resolved Hide resolved
scripts/lib/browser-sdk-version.js Outdated Show resolved Hide resolved
…tch wrapper into fetch in export bundle script. Deleted local preferences in gitignore
scripts/lib/browser-sdk-version.js Outdated Show resolved Hide resolved
@RomanGaignault
Copy link
Contributor Author

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Feb 15, 2024

🚂 Branch Integration: starting soon, merge in < 9m

Commit bf1e3dd049 will soon be integrated into staging-07.

This build is going to start soon! (estimated merge in less than 9m)

Use /to-staging -c to cancel this operation!

dd-mergequeue bot added a commit that referenced this pull request Feb 15, 2024
Co-authored-by: roman.gaignault <roman.gaignault@datadoghq.com>
@dd-devflow
Copy link
Contributor

dd-devflow bot commented Feb 15, 2024

🚂 Branch Integration: This commit was successfully integrated

Commit bf1e3dd049 has been merged into staging-07 in merge commit 6533668272.

Check out the triggered pipeline on Gitlab 🦊

@RomanGaignault RomanGaignault merged commit 84cd328 into main Feb 15, 2024
18 checks passed
@RomanGaignault RomanGaignault deleted the roman/SendBundleSizes branch February 15, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants