Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRO] update Node version #263

Merged
merged 3 commits into from
Feb 11, 2020
Merged

[MRO] update Node version #263

merged 3 commits into from
Feb 11, 2020

Conversation

BenoitZugmeyer
Copy link
Member

This updates Node to the same version we are using internally.

This updates Node to the same version we are using internally.
@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner February 11, 2020 14:43
@mquentin mquentin self-requested a review February 11, 2020 14:47
Copy link
Contributor

@bcaudan bcaudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update dockerfile in order to run gitlab jobs on this version as well

@codecov-io
Copy link

Codecov Report

Merging #263 into master will decrease coverage by 0.68%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
- Coverage   85.86%   85.18%   -0.69%     
==========================================
  Files          24       24              
  Lines        1323     1323              
  Branches      276      276              
==========================================
- Hits         1136     1127       -9     
- Misses        187      196       +9
Impacted Files Coverage Δ
packages/core/src/requestCollection.ts 82.69% <0%> (-13.47%) ⬇️
packages/logs/src/loggerSession.ts 95.45% <0%> (-4.55%) ⬇️
packages/rum/src/rum.entry.ts 69.38% <0%> (-2.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c3f55f...cb44685. Read the comment docs.

@BenoitZugmeyer BenoitZugmeyer merged commit 7e2a99d into master Feb 11, 2020
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/update-node branch February 11, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants