🐛 [RUM-3599] do not define undefined instrumented method #2662
Conversation
|
/to-staging |
|
🚂 Branch Integration: starting soon, merge in < 10m Commit e1b6ea5c12 will soon be integrated into staging-12. This build is going to start soon! (estimated merge in less than 10m) Use |
|
🚨 Branch Integration: The build pipeline contains failing jobs for this merge request We couldn't automatically merge the commit e1b6ea5c12 into staging-12. Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail. You should have a look at the pipeline, wait for the build to finish and investigate the failures.
|
BenoitZugmeyer
force-pushed
the
benoit/fix-undefined-instrument-method
branch
from
e1b6ea5 to
fa634d6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2662 +/- ##
==========================================
- Coverage 92.91% 92.90% -0.02%
==========================================
Files 239 239
Lines 6931 6934 +3
Branches 1517 1518 +1
==========================================
+ Hits 6440 6442 +2
- Misses 491 492 +1 ☔ View full report in Codecov by Sentry. |
Bundles Sizes Evolution
|
|
/to-staging |
|
🚂 Branch Integration: starting soon, merge in < 10m Commit fa634d6162 will soon be integrated into staging-12. This build is going to start soon! (estimated merge in less than 10m) Use |
|
🚂 Branch Integration: This commit was successfully integrated Commit fa634d6162 has been merged into staging-12 in merge commit e451dee258. Check out the triggered pipeline on Gitlab 🦊 |
|
/to-staging |
|
🚂 Branch Integration: starting soon, merge in < 10m Commit 7398f82784 will soon be integrated into staging-12. This build is going to start soon! (estimated merge in less than 10m) Use |
|
🚂 Branch Integration: This commit was successfully integrated Commit 7398f82784 has been merged into staging-12 in merge commit 456df7459a. Check out the triggered pipeline on Gitlab 🦊 |
| expect(object.method).toBeUndefined() | ||
| }) | ||
|
|
||
| it('sets an event handler even if it was originally undefined', () => { |
There was a problem hiding this comment.
❓ question: could you explain when this happens? and why we still want to wrap something that was originally undefined?
|
/to-staging |
|
We recommend you to add a file named schema-version: v1
kind: integration-branch
name: staging-12
team: <my-team-name>
update_automatically: true
update_at_most_every: 15m
reset_pattern: "0 12 * * Mon"
contacts:
- type: slack
contact: <my-teams-ops-channel>
---This configuration would keep your branch up-to-date with the base branch of this repository automatically and would get reset every Monday at noon UTC. For more information: Integration Branches If you need support, contact us on Slack #ci-interfaces! |
|
🚂 Branch Integration: starting soon, merge in < 10m Commit 00103f1c9d will soon be integrated into staging-12. This build is going to start soon! (estimated merge in less than 10m) Use |
|
🚂 Branch Integration: This commit was successfully integrated Commit 00103f1c9d has been merged into staging-12 in merge commit 93b5501ad1. Check out the triggered pipeline on Gitlab 🦊 |
Motivation
Some websites are removing native methods on purpose. Re-defining the method breaks them.
Changes
Don't define undefined instrumented methods.
Testing
I have gone over the contributing documentation.