Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [RUM] fix retrieving early timings #268

Merged
merged 4 commits into from
Feb 13, 2020
Merged

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Feb 13, 2020

  • Add async e2e setup to ensure that early timings are well retrieved
  • Add test to ensure that early resources are collected

@bcaudan bcaudan requested a review from a team as a code owner February 13, 2020 10:11
@bcaudan bcaudan force-pushed the bcaudan/fix-early-timing branch from 5bb37fb to c6991e5 Compare February 13, 2020 10:11
@bcaudan bcaudan force-pushed the bcaudan/fix-early-timing branch from c6991e5 to ac7884c Compare February 13, 2020 10:14
Failed to create session.
Specified OS/Browser combo is disabled: GalaxyS9-And90|MblChrome75
@bcaudan bcaudan force-pushed the bcaudan/fix-early-timing branch from 304f46a to 0c06ffc Compare February 13, 2020 10:52
@DataDog DataDog deleted a comment from codecov-io Feb 13, 2020
@codecov-io
Copy link

Codecov Report

Merging #268 into master will decrease coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #268      +/-   ##
==========================================
- Coverage   86.31%   86.23%   -0.08%     
==========================================
  Files          24       24              
  Lines        1308     1308              
  Branches      277      277              
==========================================
- Hits         1129     1128       -1     
- Misses        179      180       +1
Impacted Files Coverage Δ
packages/rum/src/rum.entry.ts 71.42% <100%> (ø) ⬆️
packages/logs/src/loggerSession.ts 95.45% <0%> (-4.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 362127f...0c06ffc. Read the comment docs.

@bcaudan bcaudan merged commit 289d73b into master Feb 13, 2020
@bcaudan bcaudan deleted the bcaudan/fix-early-timing branch February 13, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants