Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨[RUM-3798] Report the cpu impact as a pr comment #2702

Merged
merged 21 commits into from
Apr 16, 2024

Conversation

RomanGaignault
Copy link
Contributor

@RomanGaignault RomanGaignault commented Apr 10, 2024

Motivation

We want to know how much the Browser SDK is impacting the performances, and detect regressions early.

Changes

Using synthetic test we trigger a micro benchmark of actions you can perform on the sdk, measure the time used and retrieves data using logs2metrics.
image

Note : the S3 bucket contains now every built bundle of each PR. As it replaces the previous one after CI (for the same PR), only the built files for last commit before merging will be kept.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@DataDog DataDog deleted a comment from cit-pr-commenter bot Apr 10, 2024
@RomanGaignault RomanGaignault marked this pull request as ready for review April 10, 2024 11:41
@RomanGaignault RomanGaignault requested a review from a team as a code owner April 10, 2024 11:41
@RomanGaignault RomanGaignault changed the title ✨[RUM-3798]-report-the-cpu-impact-as-a-pr-comment ✨[RUM-3798]Report the cpu impact as a pr comment Apr 10, 2024
@RomanGaignault RomanGaignault changed the title ✨[RUM-3798]Report the cpu impact as a pr comment ✨[RUM-3798] Report the cpu impact as a pr comment Apr 10, 2024
@DataDog DataDog deleted a comment from cit-pr-commenter bot Apr 10, 2024
Copy link

cit-pr-commenter bot commented Apr 10, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 156.37 KiB 156.37 KiB 0 B 0.00%
Logs 55.34 KiB 55.34 KiB 0 B 0.00%
Rum Slim 102.86 KiB 102.86 KiB 0 B 0.00%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
adderror N/A 0.040 0.040
addaction N/A 0.016 0.016
logmessage N/A 0.006 0.006
startview N/A 1.313 1.313
startstopsessionreplayrecording N/A 1.043 1.043
addtiming N/A 0.001 0.001
addglobalcontext N/A 0.001 0.001

scripts/report-bundle-size/report-as-a-pr-comment.js Outdated Show resolved Hide resolved
scripts/performance/cpu-performance/synthetic-trigger.js Outdated Show resolved Hide resolved
scripts/performance/index.js Outdated Show resolved Hide resolved
scripts/performance/cpu-performance/synthetic-trigger.js Outdated Show resolved Hide resolved
scripts/deploy/lib/deployment-utils.js Outdated Show resolved Hide resolved
scripts/deploy/deploy.js Outdated Show resolved Hide resolved
scripts/performance/report-as-a-pr-comment.js Show resolved Hide resolved
@RomanGaignault RomanGaignault force-pushed the RUM-3798-report-the-cpu-impact-as-a-pr-comment branch from 98f0251 to d416e91 Compare April 15, 2024 11:54
scripts/performance/query-performance-data.js Outdated Show resolved Hide resolved
scripts/performance/report-as-a-pr-comment.js Outdated Show resolved Hide resolved
.gitlab-ci.yml Show resolved Hide resolved
@RomanGaignault RomanGaignault merged commit 1ea85f4 into main Apr 16, 2024
18 checks passed
@RomanGaignault RomanGaignault deleted the RUM-3798-report-the-cpu-impact-as-a-pr-comment branch April 16, 2024 14:41
@RomanGaignault
Copy link
Contributor Author

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Apr 16, 2024

🚂 Branch Integration: starting soon, merge in < 0s

Commit 6fa3e7acc0 will soon be integrated into staging-16.

This build is going to start soon! (estimated merge in less than 0s)

Use /to-staging -c to cancel this operation!

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Apr 16, 2024

🚨 Branch Integration: The build pipeline contains failing jobs for this merge request

We couldn't automatically merge the commit 6fa3e7acc0 into staging-16.
Build pipeline has failing jobs for df7e7e5

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected before the end of the pipeline.

You should have a look at the pipeline, wait for the build to finish and investigate the failures.
When you are ready, re-add your pull request to the queue!

⚠️ Do NOT retry failed jobs directly.

They were executed on a temporary branch created by the merge queue. If you retry them, they are going to fail because the branch no longer exists.

If you think the errors come from a logical conflict with the target branch, you can create a fix by commenting this pull request with /create-fix-branch -b staging-16

Details

List of failed jobs:

Go to failed Gitlab pipeline.

If you need support, contact us on Slack #devflow with those details!

@RomanGaignault RomanGaignault restored the RUM-3798-report-the-cpu-impact-as-a-pr-comment branch April 16, 2024 14:52
RomanGaignault added a commit that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants