Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUM-4287] Enable feature flags API #2728

Merged
merged 2 commits into from
May 3, 2024

Conversation

amortemousque
Copy link
Contributor

@amortemousque amortemousque commented Apr 25, 2024

Motivation

This PR enables sending feature flags with the API introduced in #2096

Changes

Remove the feature_flags experimental flag.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque marked this pull request as ready for review April 25, 2024 13:44
@amortemousque amortemousque requested a review from a team as a code owner April 25, 2024 13:44
Copy link
Contributor

@N-Boutaib N-Boutaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

cit-pr-commenter bot commented Apr 29, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 157.48 KiB 157.35 KiB -139 B -0.09%
Logs 56.12 KiB 56.09 KiB -32 B -0.06%
Rum Slim 103.98 KiB 103.84 KiB -139 B -0.13%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
adderror 0.029 0.043 0.013
addaction 0.014 0.018 0.003
logmessage 0.004 0.005 0.000
startview 0.818 0.804 -0.014
startstopsessionreplayrecording 0.709 0.736 0.026
addtiming 0.001 0.001 0.000
addglobalcontext 0.001 0.001 0.000

@amortemousque amortemousque force-pushed the aymeric/enable-feature-flags branch from e418d05 to 4092b36 Compare April 29, 2024 07:44
@amortemousque amortemousque force-pushed the aymeric/enable-feature-flags branch from 4092b36 to 09e87f5 Compare April 29, 2024 07:45
Copy link
Contributor

@bcaudan bcaudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@amortemousque amortemousque merged commit b4a7b65 into main May 3, 2024
19 checks passed
@amortemousque amortemousque deleted the aymeric/enable-feature-flags branch May 3, 2024 14:35
@bbrzoska
Copy link

Looks like the docs need to be updated, as they still say the flag should be added to config.

@BenoitZugmeyer
Copy link
Member

Good catch! It's being worked on :) DataDog/documentation#25073 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants