✨[RUMF-342] use startTime for events timestamp #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcaudan
changed the title
BenoitZugmeyer
approved these changes
Feb 19, 2020
packages/rum/src/viewTracker.ts
Outdated
| @@ -55,8 +55,7 @@ function newView(location: Location, session: RumSession, upsertRumEvent: (event | |||
| location: { ...location }, | |||
| sessionId: session.getId(), | |||
| } | |||
| startTimestamp = new Date().getTime() | |||
| startOrigin = performance.now() | |||
| startOrigin = isInitialView ? 0 : performance.now() | |||
There was a problem hiding this comment.
NIT: you could check if the viewContext object was defined instead of having another mutable state.
| errorObservable.notify({ message: '1', ...CONTEXT }) | ||
| errorObservable.notify({ message: '2', ...CONTEXT }) | ||
| errorObservable.notify({ message: '3', ...CONTEXT }) | ||
| errorObservable.notify({ message: '1', startTime: 100, ...CONTEXT }) |
There was a problem hiding this comment.
NIT: startTime: 100 could be in CONTEXT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use startTime instead of collection time in order to have a more accurate date for events.