Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUM-3965] make service and version fields modifiable #2788

Merged
merged 6 commits into from
Jun 5, 2024

Conversation

thomas-lebeau
Copy link
Collaborator

@thomas-lebeau thomas-lebeau commented May 30, 2024

Motivation

As part of the micro frontend support, we are allowing customer to override service and version properties of most events

Changes

Adds service and version to the list of modifiable properties for error, action and resource event types.
Note: logs events not protected against modifications

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.59%. Comparing base (08fd978) to head (7d87b9d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2788   +/-   ##
=======================================
  Coverage   93.59%   93.59%           
=======================================
  Files         243      243           
  Lines        7068     7072    +4     
  Branches     1567     1570    +3     
=======================================
+ Hits         6615     6619    +4     
  Misses        453      453           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cit-pr-commenter bot commented May 30, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 157.98 KiB 158.05 KiB 71 B +0.04%
Logs 56.71 KiB 56.71 KiB 0 B 0.00%
Rum Slim 104.54 KiB 104.61 KiB 71 B +0.07%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.001 0.002 0.000
addaction 0.031 0.032 0.002
adderror 0.033 0.035 0.002
addtiming 0.001 0.001 0.000
startview 0.844 0.870 0.026
startstopsessionreplayrecording 0.717 0.855 0.139
logmessage 0.004 0.005 0.000
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫
addglobalcontext 18.88 KiB 19.83 KiB NaN KiB
addaction 68.50 KiB 68.16 KiB NaN KiB
adderror 85.50 KiB 86.74 KiB NaN KiB
addtiming 17.12 KiB 18.21 KiB NaN KiB
startview NaN KiB 317.32 KiB NaN KiB
startstopsessionreplayrecording 12.44 KiB 13.16 KiB NaN KiB
logmessage 65.36 KiB 64.41 KiB NaN KiB

@thomas-lebeau thomas-lebeau force-pushed the thomas.lebeau/mf-service-modify branch from f38ee40 to 642dbf0 Compare May 30, 2024 12:35
@thomas-lebeau thomas-lebeau force-pushed the thomas.lebeau/mf-service-modify branch from 642dbf0 to ce7b743 Compare May 30, 2024 12:36
@thomas-lebeau thomas-lebeau marked this pull request as ready for review May 30, 2024 14:43
@thomas-lebeau thomas-lebeau requested a review from a team as a code owner May 30, 2024 14:43
Copy link
Contributor

@N-Boutaib N-Boutaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Could you add a small unit test, in assembly.spec.ts, to cover that service & version are editable only if the FF is enabled ?

@thomas-lebeau thomas-lebeau force-pushed the thomas.lebeau/mf-service-modify branch from b63797b to dcca59c Compare June 3, 2024 14:20
@thomas-lebeau thomas-lebeau force-pushed the thomas.lebeau/mf-service-modify branch from 08f6c87 to 7d87b9d Compare June 4, 2024 12:13
@thomas-lebeau
Copy link
Collaborator Author

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Jun 4, 2024

🚂 Branch Integration: starting soon, median merge time is 9m

Commit 7d87b9dae9 will soon be integrated into staging-23.

Use /to-staging -c to cancel this operation!

dd-mergequeue bot added a commit that referenced this pull request Jun 4, 2024
Integrated commit sha: 7d87b9d

Co-authored-by: Thomas Lebeau <thomas.lebeau@datadoghq.com>
@dd-devflow
Copy link
Contributor

dd-devflow bot commented Jun 4, 2024

🚂 Branch Integration: This commit was successfully integrated

Commit 7d87b9dae9 has been merged into staging-23 in merge commit d3d8eb8b59.

Check out the triggered pipeline on Gitlab 🦊

@dd-devflow dd-devflow bot added the staging-23 label Jun 4, 2024
@thomas-lebeau thomas-lebeau merged commit 53afd4c into main Jun 5, 2024
21 checks passed
@thomas-lebeau thomas-lebeau deleted the thomas.lebeau/mf-service-modify branch June 5, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants