-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [RUM-3965] make service and version fields modifiable #2788
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2788 +/- ##
=======================================
Coverage 93.59% 93.59%
=======================================
Files 243 243
Lines 7068 7072 +4
Branches 1567 1570 +3
=======================================
+ Hits 6615 6619 +4
Misses 453 453 ☔ View full report in Codecov by Sentry. |
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
f38ee40
to
642dbf0
Compare
642dbf0
to
ce7b743
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Could you add a small unit test, in assembly.spec.ts
, to cover that service
& version
are editable only if the FF is enabled ?
b63797b
to
dcca59c
Compare
08f6c87
to
7d87b9d
Compare
/to-staging |
🚂 Branch Integration: starting soon, median merge time is 9m Commit 7d87b9dae9 will soon be integrated into staging-23. Use |
Integrated commit sha: 7d87b9d Co-authored-by: Thomas Lebeau <thomas.lebeau@datadoghq.com>
🚂 Branch Integration: This commit was successfully integrated Commit 7d87b9dae9 has been merged into staging-23 in merge commit d3d8eb8b59. Check out the triggered pipeline on Gitlab 🦊 |
Motivation
As part of the micro frontend support, we are allowing customer to override
service
andversion
properties of most eventsChanges
Adds
service
andversion
to the list of modifiable properties forerror
,action
andresource
event types.Note: logs events not protected against modifications
Testing
I have gone over the contributing documentation.