Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix developer extension crashing when dev mode enabled #2810

Conversation

thomas-lebeau
Copy link
Collaborator

@thomas-lebeau thomas-lebeau commented Jun 14, 2024

Motivation

Fix issue with the developer extension when dev mode option is enabled:

Screenshot 2024-06-14 at 12 36 36

Changes

Makes sure _setDebug exists before calling it (same as in overrideInitConfiguration)

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @thomas-lebeau and the rest of your teammates on Graphite Graphite

Copy link

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 160.13 KiB 160.13 KiB 0 B 0.00%
Logs 58.07 KiB 58.07 KiB 0 B 0.00%
Rum Slim 108.65 KiB 108.65 KiB 0 B 0.00%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.001 0.001 0.000
addaction 0.036 0.031 -0.005
adderror 0.033 0.035 0.002
addtiming 0.001 0.001 0.000
startview 0.955 1.104 0.149
startstopsessionreplayrecording 0.805 0.913 0.108
logmessage 0.020 0.020 0.000
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 19.56 KiB 19.87 KiB 322 B
addaction 69.05 KiB 69.81 KiB 777 B
adderror 84.02 KiB 86.25 KiB 2.23 KiB
addtiming 18.22 KiB 16.66 KiB -1595 B
startview 313.07 KiB 320.69 KiB 7.61 KiB
startstopsessionreplayrecording 12.84 KiB 10.61 KiB -2284 B
logmessage 68.11 KiB 67.38 KiB -751 B

🔗 RealWorld

@thomas-lebeau thomas-lebeau marked this pull request as ready for review June 14, 2024 11:02
@thomas-lebeau thomas-lebeau requested a review from a team as a code owner June 14, 2024 11:02
@thomas-lebeau thomas-lebeau merged commit feb10de into main Jun 14, 2024
20 checks passed
@thomas-lebeau thomas-lebeau deleted the thomas.lebeau/06-14-_fix_developer_extension_crashing_when_dev_mode_enabled branch June 14, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants