Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 engine.io and socket.io-adapter packages to fix ws vulnerability #2842

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

N-Boutaib
Copy link
Contributor

Motivation

https://github.com/DataDog/browser-sdk/security/dependabot/82

Changes

Upgrade of messed yarn.lock file

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@N-Boutaib N-Boutaib marked this pull request as ready for review July 2, 2024 08:15
@N-Boutaib N-Boutaib requested a review from a team as a code owner July 2, 2024 08:15
Copy link

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 160.25 KiB 160.25 KiB 0 B 0.00%
Logs 57.91 KiB 57.91 KiB 0 B 0.00%
Rum Slim 108.77 KiB 108.77 KiB 0 B 0.00%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.001 0.002 0.001
addaction 0.030 0.040 0.010
adderror 0.032 0.052 0.021
addtiming 0.001 0.001 0.000
startview 0.893 1.071 0.178
startstopsessionreplayrecording 0.771 1.057 0.285
logmessage 0.020 0.023 0.004
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 22.20 KiB 20.56 KiB -1677 B
addaction 71.94 KiB 70.18 KiB -1806 B
adderror 88.93 KiB 86.62 KiB -2360 B
addtiming 21.90 KiB 18.73 KiB -3246 B
startview 314.64 KiB 320.26 KiB 5.62 KiB
startstopsessionreplayrecording 13.51 KiB 15.51 KiB 2.00 KiB
logmessage 72.84 KiB 69.76 KiB -3149 B

🔗 RealWorld

@N-Boutaib N-Boutaib merged commit 01bd59f into main Jul 2, 2024
20 checks passed
@N-Boutaib N-Boutaib deleted the najib.boutaib/re-bump-ws-version-to-8.17.1 branch July 2, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants