-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix update view name api in context history #2853
🐛 Fix update view name api in context history #2853
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2853 +/- ##
=======================================
Coverage 93.66% 93.66%
=======================================
Files 266 266
Lines 7573 7577 +4
Branches 1683 1684 +1
=======================================
+ Hits 7093 7097 +4
Misses 480 480 ☔ View full report in Codecov by Sentry. |
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
/to-staging |
🚂 Branch Integration: starting soon, median merge time is 11m Commit 45c6bed16c will soon be integrated into staging-28. Use |
…aging-28 Integrated commit sha: 45c6bed Co-authored-by: roman.gaignault <roman.gaignault@datadoghq.com>
🚂 Branch Integration: This commit was successfully integrated Commit 45c6bed16c has been merged into staging-28 in merge commit 3d877481d9. Check out the triggered pipeline on Gitlab 🦊 |
Motivation
The API 'update view name' doesn't update the last view in the context history. This mean next events such as action would not be linked to the view with the new name.
Changes
Added a subscribe to view_updated, so it update the last view from the context history with the correct name.
Testing
I have gone over the contributing documentation.