Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix update view name api in context history #2853

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

RomanGaignault
Copy link
Contributor

@RomanGaignault RomanGaignault commented Jul 9, 2024

Motivation

The API 'update view name' doesn't update the last view in the context history. This mean next events such as action would not be linked to the view with the new name.

Changes

Added a subscribe to view_updated, so it update the last view from the context history with the correct name.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.66%. Comparing base (30ae145) to head (45c6bed).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2853   +/-   ##
=======================================
  Coverage   93.66%   93.66%           
=======================================
  Files         266      266           
  Lines        7573     7577    +4     
  Branches     1683     1684    +1     
=======================================
+ Hits         7093     7097    +4     
  Misses        480      480           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cit-pr-commenter bot commented Jul 9, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 161.37 KiB 161.46 KiB 94 B +0.06%
Logs 57.97 KiB 57.97 KiB 0 B 0.00%
Rum Slim 109.89 KiB 109.98 KiB 94 B +0.08%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.002 0.002 0.000
addaction 0.034 0.031 -0.003
adderror 0.051 0.034 -0.017
addtiming 0.001 0.001 -0.000
startview 1.230 0.991 -0.240
startstopsessionreplayrecording 0.906 0.853 -0.053
logmessage 0.023 0.019 -0.003
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 22.05 KiB 21.28 KiB -792 B
addaction 73.70 KiB 75.42 KiB 1.72 KiB
adderror 88.13 KiB 87.80 KiB -332 B
addtiming 19.17 KiB 17.18 KiB -2036 B
startview 333.58 KiB 350.93 KiB 17.35 KiB
startstopsessionreplayrecording 16.50 KiB 14.14 KiB -2415 B
logmessage 71.05 KiB 70.62 KiB -441 B

🔗 RealWorld

@RomanGaignault RomanGaignault marked this pull request as ready for review July 9, 2024 14:41
@RomanGaignault RomanGaignault requested a review from a team as a code owner July 9, 2024 14:41
@RomanGaignault
Copy link
Contributor Author

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Jul 11, 2024

🚂 Branch Integration: starting soon, median merge time is 11m

Commit 45c6bed16c will soon be integrated into staging-28.

Use /to-staging -c to cancel this operation!

dd-mergequeue bot added a commit that referenced this pull request Jul 11, 2024
…aging-28

Integrated commit sha: 45c6bed

Co-authored-by: roman.gaignault <roman.gaignault@datadoghq.com>
@dd-devflow
Copy link
Contributor

dd-devflow bot commented Jul 11, 2024

🚂 Branch Integration: This commit was successfully integrated

Commit 45c6bed16c has been merged into staging-28 in merge commit 3d877481d9.

Check out the triggered pipeline on Gitlab 🦊

@RomanGaignault RomanGaignault merged commit 7b8480d into main Jul 12, 2024
21 checks passed
@RomanGaignault RomanGaignault deleted the roman/update-view-name-view-history-context branch July 12, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants