Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rum-react peerDependencies #2870

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

nulrich
Copy link
Contributor

@nulrich nulrich commented Jul 17, 2024

Motivation

rum-react package peerDependencies on @datadog/browser-core and @datadog/browser-rum-core are not updated by release script.

Changes

  • Reading the content of ./packages to retrieve packages name.
  • Update packages with peerDependencies on @datadog modules.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@nulrich nulrich marked this pull request as ready for review July 17, 2024 11:13
@nulrich nulrich requested a review from a team as a code owner July 17, 2024 11:13
@nulrich nulrich requested review from BenoitZugmeyer and a team July 17, 2024 11:18
Copy link

cit-pr-commenter bot commented Jul 17, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 0 B 161.66 KiB 161.66 KiB N/A%
Logs 0 B 57.97 KiB 57.97 KiB N/A%
Rum Slim 0 B 110.18 KiB 110.18 KiB N/A%
Worker 0 B 25.21 KiB 25.21 KiB N/A%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext N/A 0.002 0.002
addaction N/A 0.034 0.034
adderror N/A 0.033 0.033
addtiming N/A 0.001 0.001
startview N/A 1.074 1.074
startstopsessionreplayrecording N/A 0.983 0.983
logmessage N/A 0.020 0.020
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext NaN KiB 21.64 KiB NaN KiB
addaction NaN KiB 73.52 KiB NaN KiB
adderror NaN KiB 87.89 KiB NaN KiB
addtiming NaN KiB 19.52 KiB NaN KiB
startview NaN KiB 354.66 KiB NaN KiB
startstopsessionreplayrecording NaN KiB 13.92 KiB NaN KiB
logmessage NaN KiB 72.35 KiB NaN KiB

🔗 RealWorld

@@ -3,7 +3,9 @@ const { modifyFile } = require('../lib/files-utils')
const { command } = require('../lib/command')
const { browserSdkVersion } = require('../lib/browser-sdk-version')

const JSON_FILES = ['rum', 'rum-slim', 'logs'].map((packageName) => `./packages/${packageName}/package.json`)
const JSON_FILES = ['rum', 'rum-slim', 'logs', 'rum-react'].map(
(packageName) => `./packages/${packageName}/package.json`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭 thought: I wonder if we could avoid hardcoding package names here, like using fs.readDirSync('packages')

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@nulrich nulrich merged commit fa6115b into main Jul 17, 2024
20 checks passed
@nulrich nulrich deleted the nicolas.ulrich/rum-react-release-script branch July 17, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants