Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚗️ enable plugins as a beta feature #2872

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Conversation

BenoitZugmeyer
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer commented Jul 17, 2024

Motivation

We want to expose plugins to customers, but this should still be considered as "beta".

Changes

  • Remove "PLUGINS" feature flag
  • rename init config "plugins" to "betaPlugins"

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@BenoitZugmeyer BenoitZugmeyer requested a review from a team as a code owner July 17, 2024 14:56
Copy link

cit-pr-commenter bot commented Jul 17, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 161.66 KiB 161.62 KiB -39 B -0.02%
Logs 57.97 KiB 57.95 KiB -20 B -0.03%
Rum Slim 110.18 KiB 110.14 KiB -39 B -0.03%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.002 0.002 0.000
addaction 0.032 0.032 0.001
adderror 0.039 0.037 -0.002
addtiming 0.001 0.001 0.000
startview 0.924 1.186 0.262
startstopsessionreplayrecording 0.855 0.851 -0.004
logmessage 0.020 0.019 -0.001
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 19.07 KiB 19.51 KiB 454 B
addaction 74.22 KiB 73.62 KiB -606 B
adderror 88.98 KiB 87.21 KiB -1808 B
addtiming 18.51 KiB 17.49 KiB -1048 B
startview 348.81 KiB 353.84 KiB 5.03 KiB
startstopsessionreplayrecording 15.34 KiB 12.83 KiB -2575 B
logmessage 72.56 KiB 70.09 KiB -2522 B

🔗 RealWorld

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.68%. Comparing base (1aea760) to head (87f0660).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2872      +/-   ##
==========================================
+ Coverage   93.67%   93.68%   +0.01%     
==========================================
  Files         266      266              
  Lines        7586     7584       -2     
  Branches     1688     1687       -1     
==========================================
- Hits         7106     7105       -1     
+ Misses        480      479       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BenoitZugmeyer BenoitZugmeyer merged commit 2490414 into main Jul 18, 2024
20 checks passed
@BenoitZugmeyer BenoitZugmeyer deleted the benoit/beta-plugins branch July 18, 2024 08:41
RomanGaignault pushed a commit that referenced this pull request Jul 23, 2024
* ⚗️ enable plugins as a beta feature

* update sandbox app

* fix tests and lints
RomanGaignault pushed a commit that referenced this pull request Jul 24, 2024
* ⚗️ enable plugins as a beta feature

* update sandbox app

* fix tests and lints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants