-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [RUM-5775] Make view local context writable #2939
Conversation
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2939 +/- ##
==========================================
- Coverage 93.48% 93.48% -0.01%
==========================================
Files 271 271
Lines 7616 7623 +7
Branches 1696 1700 +4
==========================================
+ Hits 7120 7126 +6
- Misses 496 497 +1 ☔ View full report in Codecov by Sentry. |
1b42769
to
988dc95
Compare
945ea4c
to
2935eee
Compare
@@ -45,6 +46,7 @@ export function startViewContexts(lifeCycle: LifeCycle): ViewContexts { | |||
return { | |||
service: view.service, | |||
version: view.version, | |||
customerContext: view.context, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💬 suggestion: I'm not a big fan of the customer
prefix here. Other properties of this interface also come from the customer, so it feels weird to specify customer
for context.
I understand you are using customerContext
instead of context
to avoid having a context
field on an interface that is already called xxxContext
? I agree that's too many context! But I would rather rename ViewContext
to something like ViewHistoryEntry
(as I suggested in the RFC) instead of using customerContext
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm moving this renaming to another PR. Still in draft: #2953
2f97af7
to
840a1e7
Compare
840a1e7
to
70826ae
Compare
Motivation
Enable users to set the view specific context with existing apis:
Changes
USER_CUSTOMIZABLE_FIELD_PATHS
for view in event assemblyview_specific_context
Testing
I have gone over the contributing documentation.