-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 [RUM-5100] Move away from testbuilder in test files - Pt 3 #2952
🎨 [RUM-5100] Move away from testbuilder in test files - Pt 3 #2952
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2952 +/- ##
==========================================
+ Coverage 93.50% 93.57% +0.07%
==========================================
Files 271 273 +2
Lines 7637 7597 -40
Branches 1705 1707 +2
==========================================
- Hits 7141 7109 -32
+ Misses 496 488 -8 ☔ View full report in Codecov by Sentry. |
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
function setupRecorderApi({ | ||
sessionManager, | ||
startSessionReplayRecordingManually, | ||
}: { sessionManager?: RumSessionManager; startSessionReplayRecordingManually?: boolean } = {}) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Motivation
Removing the last occurrences of
TestBuilder
and improving spec files by removing casting and using unified default RumConfiguration.Changes
{} as RumConfiguration
Testing
I have gone over the contributing documentation.