-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [RUM-94] ignore performance resource timings with negative duration #2958
🐛 [RUM-94] ignore performance resource timings with negative duration #2958
Conversation
/to-staging |
🚂 Branch Integration: starting soon, median merge time is 0s Commit a32799d88a will soon be integrated into staging-35. Use |
🚂 Branch Integration: This commit was successfully integrated Commit a32799d88a has been merged into staging-35 in merge commit a4509b1255. Check out the triggered pipeline on Gitlab 🦊 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2958 +/- ##
=======================================
Coverage 93.42% 93.43%
=======================================
Files 271 271
Lines 7637 7641 +4
Branches 1704 1706 +2
=======================================
+ Hits 7135 7139 +4
Misses 502 502 ☔ View full report in Codecov by Sentry. |
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
Motivation
Starting with Chrome 128, blob URLs are reported as PerformanceResourceTiming entries. Those entries have (always?) negative durations, which is unexpected. The intake rejects RUM Resource events with negative duration already, so sending them is useless and breaks our e2e tests when validating the events against the rum-events-format.
Changes
Let's ignore resource entries with negative duration.
Note: I opened a Chromium issue about this, but in the meantime, there is absolutely no value in sending those entries to the intake.
This PR also rename a bunch of "PerformanceResourceTiming"-related function to have consistent naming.
Testing
I have gone over the contributing documentation.