Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ [RUM-6181] Use performanceObserver for LCP entries #2990

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

amortemousque
Copy link
Contributor

@amortemousque amortemousque commented Sep 13, 2024

Motivation

Following the introduction of performanceObservable to move away from performanceCollection: PR
Let use performanceObservable for LCP entries.

Changes

  • Remove LCP from performanceCollection
  • Use perfomanceObservable in trackLargestContentfulPaint

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@amortemousque amortemousque requested a review from a team as a code owner September 13, 2024 14:55
@amortemousque amortemousque force-pushed the aymeric/use-performance-observable-LCP branch 2 times, most recently from 0ca7464 to 6654258 Compare September 13, 2024 15:20
@amortemousque amortemousque force-pushed the aymeric/use-performance-observable-LCP branch from 6654258 to 9c7a19c Compare September 16, 2024 07:58
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.54%. Comparing base (a0d918c) to head (6f1ef52).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2990   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files         273      273           
  Lines        7605     7605           
  Branches     1709     1709           
=======================================
  Hits         7114     7114           
  Misses        491      491           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cit-pr-commenter bot commented Sep 16, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 0 B 161.34 KiB 161.34 KiB N/A%
Logs 0 B 56.12 KiB 56.12 KiB N/A%
Rum Slim 0 B 109.95 KiB 109.95 KiB N/A%
Worker 0 B 25.21 KiB 25.21 KiB N/A%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext N/A 0.002 0.002
addaction N/A 0.042 0.042
addtiming N/A 0.001 0.001
adderror N/A 0.059 0.059
startstopsessionreplayrecording N/A 0.933 0.933
startview N/A 1.102 1.102
logmessage N/A 0.021 0.021
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext NaN KiB 8.39 KiB NaN KiB
addaction NaN KiB 38.77 KiB NaN KiB
addtiming NaN KiB 6.58 KiB NaN KiB
adderror NaN KiB 43.00 KiB NaN KiB
startstopsessionreplayrecording NaN KiB 4.84 KiB NaN KiB
startview NaN KiB 346.52 KiB NaN KiB
logmessage NaN KiB 40.64 KiB NaN KiB

🔗 RealWorld

@amortemousque amortemousque merged commit a363c34 into main Sep 17, 2024
19 checks passed
@amortemousque amortemousque deleted the aymeric/use-performance-observable-LCP branch September 17, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants