-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ [RUM-6188] Use performanceObserver for first input and event entries #2995
♻️ [RUM-6188] Use performanceObserver for first input and event entries #2995
Conversation
d0657ac
to
ccf94b7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2995 +/- ##
==========================================
- Coverage 93.38% 93.36% -0.02%
==========================================
Files 275 276 +1
Lines 7639 7647 +8
Branches 1716 1716
==========================================
+ Hits 7134 7140 +6
- Misses 505 507 +2 ☔ View full report in Codecov by Sentry. |
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
ccf94b7
to
ce5e23c
Compare
const firstInputDelay = elapsed(firstInputEntry.startTime, firstInputEntry.processingStart) | ||
let firstInputTargetSelector | ||
const performanceFirstInputSubscription = createPerformanceObservable(configuration, { | ||
type: RumPerformanceEntryType.FIRST_INPUT, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: you could remove the condition on entryType
below
Motivation
Following the introduction of
performanceObservable
to move away fromperformanceCollection
: PRLet use
performanceObservable
for first input and event entries.Changes
performanceCollection
perfomanceObservable
intrackFirstInput
perfomanceObservable
intrackInteractionToNextPaint
Testing
I have gone over the contributing documentation.