✨replace react-router wildcard routes with their actual path name #3023
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
React Router routes defined with a '*' as a path are often used to create custom routing logic. It doesn't bring much value within a View name, as it could lead to very different pages.
Changes
Replace the wildcards with the actual path they are matching. For example, with the following router:
Accessing
/foo/bar
will create the view name/foo/bar
instead of/foo/*
.Testing
I have gone over the contributing documentation.