Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUM 4813] Remove feature flag for view specific context #3031

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

cy-moi
Copy link
Contributor

@cy-moi cy-moi commented Sep 23, 2024

Motivation

Make view specific context apis public without experimental feature flag.

Changes

Removed feature flag and set APIs public by defualt.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@cy-moi cy-moi marked this pull request as ready for review September 24, 2024 08:12
@cy-moi cy-moi requested a review from a team as a code owner September 24, 2024 08:12
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.36%. Comparing base (8baa800) to head (c8b0ecb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3031      +/-   ##
==========================================
- Coverage   93.37%   93.36%   -0.01%     
==========================================
  Files         276      276              
  Lines        7649     7643       -6     
  Branches     1717     1712       -5     
==========================================
- Hits         7142     7136       -6     
  Misses        507      507              
Flag Coverage Δ
93.36% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 161.95 KiB 161.77 KiB -182 B -0.11%
Logs 56.03 KiB 55.99 KiB -48 B -0.08%
Rum Slim 110.52 KiB 110.34 KiB -182 B -0.16%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.002 0.003 0.001
addaction 0.048 0.073 0.024
addtiming 0.001 0.001 0.000
adderror 0.045 0.062 0.016
startstopsessionreplayrecording 1.350 1.876 0.526
startview 1.201 2.170 0.969
logmessage 0.028 0.046 0.018
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 7.59 KiB 7.73 KiB 135 B
addaction 38.60 KiB 38.57 KiB -30 B
addtiming 6.20 KiB 6.27 KiB 74 B
adderror 43.97 KiB 44.89 KiB 939 B
startstopsessionreplayrecording 5.77 KiB 3.95 KiB -1863 B
startview 437.46 KiB 443.75 KiB 6.29 KiB
logmessage 39.89 KiB 39.82 KiB -70 B

🔗 RealWorld

@cy-moi cy-moi merged commit 8b5833c into main Sep 25, 2024
19 checks passed
@cy-moi cy-moi deleted the congyao/RUM-4831-remove-view-context-ff branch September 25, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants