Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 bump e2e-bs ci job timeout to 35 minutes #3044

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

thomas-lebeau
Copy link
Collaborator

Motivation

Bump timeout a bit as job can sometimes take a bit longer, especially when waiting for the job to start the runner.

Changes

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@thomas-lebeau thomas-lebeau marked this pull request as ready for review September 26, 2024 10:04
@thomas-lebeau thomas-lebeau requested a review from a team as a code owner September 26, 2024 10:04
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.39%. Comparing base (f37adef) to head (30fe68e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3044      +/-   ##
==========================================
- Coverage   93.57%   93.39%   -0.19%     
==========================================
  Files         275      275              
  Lines        7610     7610              
  Branches     1707     1707              
==========================================
- Hits         7121     7107      -14     
- Misses        489      503      +14     
Flag Coverage Δ
93.39% <ø> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 160.91 KiB 160.91 KiB 0 B 0.00%
Logs 55.99 KiB 55.99 KiB 0 B 0.00%
Rum Slim 109.48 KiB 109.48 KiB 0 B 0.00%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.002 0.003 0.001
addaction 0.039 0.081 0.042
addtiming 0.001 0.002 0.001
adderror 0.030 0.097 0.066
startstopsessionreplayrecording 0.889 3.655 2.766
startview 1.039 7.077 6.039
logmessage 0.021 0.075 0.055
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 8.01 KiB 7.28 KiB -748 B
addaction 39.71 KiB 39.36 KiB -355 B
addtiming 6.47 KiB 6.61 KiB 146 B
adderror 43.61 KiB 42.79 KiB -831 B
startstopsessionreplayrecording 4.67 KiB 3.93 KiB -758 B
startview 461.45 KiB 464.24 KiB 2.79 KiB
logmessage 39.74 KiB 39.05 KiB -709 B

🔗 RealWorld

@thomas-lebeau thomas-lebeau merged commit 005c54c into main Sep 26, 2024
19 checks passed
@thomas-lebeau thomas-lebeau deleted the thomas.lebeau/bump-timeout branch September 26, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants