Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 add missing start_time #3050

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

thomas-lebeau
Copy link
Collaborator

@thomas-lebeau thomas-lebeau commented Oct 2, 2024

Motivation

We need to send the raw start_time property as it serve as a reference for calculating various timings:

Screenshot 2024-10-03 at 15 55 35

Changes

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.66%. Comparing base (f0dea09) to head (c6141db).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3050      +/-   ##
==========================================
+ Coverage   93.48%   93.66%   +0.18%     
==========================================
  Files         275      275              
  Lines        7610     7610              
  Branches     1707     1707              
==========================================
+ Hits         7114     7128      +14     
+ Misses        496      482      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 160.93 KiB 160.95 KiB 27 B +0.02%
Logs 56.00 KiB 56.00 KiB 0 B 0.00%
Rum Slim 109.50 KiB 109.53 KiB 27 B +0.02%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.002 0.001 -0.001
addaction 0.055 0.031 -0.024
addtiming 0.001 0.001 -0.001
adderror 0.058 0.031 -0.026
startstopsessionreplayrecording 1.281 0.975 -0.306
startview 1.890 0.954 -0.937
logmessage 0.029 0.023 -0.005
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 8.24 KiB 6.99 KiB -1274 B
addaction 41.01 KiB 38.95 KiB -2105 B
addtiming 6.19 KiB 6.51 KiB 330 B
adderror 44.09 KiB 44.36 KiB 285 B
startstopsessionreplayrecording 4.15 KiB 4.02 KiB -128 B
startview 458.81 KiB 465.36 KiB 6.56 KiB
logmessage 39.70 KiB 39.62 KiB -80 B

🔗 RealWorld

@thomas-lebeau
Copy link
Collaborator Author

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Oct 2, 2024

🚂 Branch Integration: starting soon, median merge time is 12m

Commit c6141db38f will soon be integrated into staging-40.

Use /to-staging -c to cancel this operation!

dd-mergequeue bot added a commit that referenced this pull request Oct 2, 2024
Integrated commit sha: c6141db

Co-authored-by: Thomas Lebeau <thomas.lebeau@datadoghq.com>
@dd-devflow
Copy link
Contributor

dd-devflow bot commented Oct 2, 2024

🚂 Branch Integration: This commit was successfully integrated

Commit c6141db38f has been merged into staging-40 in merge commit 0247475691.

Check out the triggered pipeline on Gitlab 🦊

@dd-devflow dd-devflow bot added the staging-40 label Oct 2, 2024
@thomas-lebeau thomas-lebeau marked this pull request as ready for review October 3, 2024 13:56
@thomas-lebeau thomas-lebeau requested a review from a team as a code owner October 3, 2024 13:56
@thomas-lebeau thomas-lebeau merged commit e7fa112 into main Oct 4, 2024
20 checks passed
@thomas-lebeau thomas-lebeau deleted the thomas.lebeau/loaf-start-time branch October 4, 2024 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants