Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Use registerCleanupTask for visibilityState cleanup #3063

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

amortemousque
Copy link
Contributor

@amortemousque amortemousque commented Oct 9, 2024

Motivation

Use registerCleanupTask for visibilityState cleanup

Changes

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.47%. Comparing base (0dfe314) to head (2621e5d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3063   +/-   ##
=======================================
  Coverage   93.47%   93.47%           
=======================================
  Files         280      280           
  Lines        7703     7703           
  Branches     1727     1727           
=======================================
  Hits         7200     7200           
  Misses        503      503           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cit-pr-commenter bot commented Oct 9, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 162.12 KiB 162.12 KiB 0 B 0.00%
Logs 55.84 KiB 55.84 KiB 0 B 0.00%
Rum Slim 110.96 KiB 110.96 KiB 0 B 0.00%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.002 0.001 -0.001
addaction 0.067 0.042 -0.024
addtiming 0.001 0.001 -0.000
adderror 0.060 0.055 -0.005
startstopsessionreplayrecording 1.622 1.116 -0.506
startview 1.729 0.391 -1.338
logmessage 0.031 0.027 -0.004
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 8.15 KiB 9.55 KiB 1.40 KiB
addaction 39.36 KiB 42.18 KiB 2.83 KiB
addtiming 7.06 KiB 7.74 KiB 700 B
adderror 44.08 KiB 44.89 KiB 832 B
startstopsessionreplayrecording 4.42 KiB 6.56 KiB 2.13 KiB
startview 419.61 KiB 428.77 KiB 9.16 KiB
logmessage 39.04 KiB 42.97 KiB 3.94 KiB

🔗 RealWorld

@amortemousque amortemousque marked this pull request as ready for review October 10, 2024 09:40
@amortemousque amortemousque requested a review from a team as a code owner October 10, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants