Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 [RUM-6562] Enable and rename update view name API #3099

Merged
merged 4 commits into from
Nov 4, 2024

Conversation

RomanGaignault
Copy link
Contributor

@RomanGaignault RomanGaignault commented Oct 28, 2024

Motivation

An "updateViewName" function has been introduced in RUM-4819
This function has been dogfooded by RUM-apps, and was proven useful.

Changes

Rename it to setViewName to match the newly introduced setViewContext / remove the experimental flag

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@RomanGaignault RomanGaignault requested a review from a team as a code owner October 28, 2024 12:35
Copy link

cit-pr-commenter bot commented Oct 28, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 161.12 KiB 161.00 KiB -121 B -0.07%
Logs 55.80 KiB 55.76 KiB -38 B -0.07%
Rum Slim 109.69 KiB 109.57 KiB -121 B -0.11%
Worker 25.21 KiB 25.21 KiB 0 B 0.00%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext 0.002 0.002 0.001
addaction 0.033 0.055 0.021
addtiming 0.001 0.001 0.000
adderror 0.033 0.051 0.018
startstopsessionreplayrecording 0.927 1.510 0.583
startview 1.112 1.519 0.407
logmessage 0.019 0.031 0.012
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext 7.99 KiB 7.03 KiB -977 B
addaction 39.94 KiB 40.12 KiB 182 B
addtiming 7.16 KiB 6.11 KiB -1075 B
adderror 44.32 KiB 44.35 KiB 26 B
startstopsessionreplayrecording 5.59 KiB 4.88 KiB -728 B
startview 461.89 KiB 468.44 KiB 6.56 KiB
logmessage 41.74 KiB 39.07 KiB -2737 B

🔗 RealWorld

packages/rum-core/src/boot/rumPublicApi.ts Outdated Show resolved Hide resolved
test/e2e/scenario/rum/init.scenario.ts Outdated Show resolved Hide resolved
packages/rum-core/src/boot/rumPublicApi.spec.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.05%. Comparing base (11c1fdd) to head (b4eee48).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3099      +/-   ##
==========================================
- Coverage   93.64%   93.05%   -0.60%     
==========================================
  Files         276      276              
  Lines        7620     7616       -4     
  Branches     1711     1709       -2     
==========================================
- Hits         7136     7087      -49     
- Misses        484      529      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/rum-core/src/boot/rumPublicApi.ts Outdated Show resolved Hide resolved
packages/rum-core/src/domain/view/trackViews.spec.ts Outdated Show resolved Hide resolved
packages/rum-core/src/domain/view/trackViews.spec.ts Outdated Show resolved Hide resolved
packages/rum-core/src/domain/view/trackViews.spec.ts Outdated Show resolved Hide resolved
@RomanGaignault
Copy link
Contributor Author

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Nov 4, 2024

🚂 Branch Integration: starting soon, median merge time is 0s

Commit b4eee488c5 will soon be integrated into staging-45.

Use /to-staging -c to cancel this operation!

dd-mergequeue bot added a commit that referenced this pull request Nov 4, 2024
Integrated commit sha: b4eee48

Co-authored-by: roman.gaignault <roman.gaignault@datadoghq.com>
@dd-devflow
Copy link
Contributor

dd-devflow bot commented Nov 4, 2024

🚂 Branch Integration: This commit was successfully integrated

Commit b4eee488c5 has been merged into staging-45 in merge commit 44ec5ff3f5.

Check out the triggered pipeline on Gitlab 🦊

@dd-devflow dd-devflow bot added the staging-45 label Nov 4, 2024
@RomanGaignault RomanGaignault merged commit 2016e15 into main Nov 4, 2024
20 checks passed
@RomanGaignault RomanGaignault deleted the romanG/update-view-name-api branch November 4, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants