-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👷 [RUM-6562] Enable and rename update view name API #3099
Conversation
Bundles Sizes Evolution
🚀 CPU Performance
🧠 Memory Performance
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3099 +/- ##
==========================================
- Coverage 93.64% 93.05% -0.60%
==========================================
Files 276 276
Lines 7620 7616 -4
Branches 1711 1709 -2
==========================================
- Hits 7136 7087 -49
- Misses 484 529 +45 ☔ View full report in Codecov by Sentry. |
/to-staging |
🚂 Branch Integration: starting soon, median merge time is 0s Commit b4eee488c5 will soon be integrated into staging-45. Use |
Integrated commit sha: b4eee48 Co-authored-by: roman.gaignault <roman.gaignault@datadoghq.com>
🚂 Branch Integration: This commit was successfully integrated Commit b4eee488c5 has been merged into staging-45 in merge commit 44ec5ff3f5. Check out the triggered pipeline on Gitlab 🦊 |
Motivation
An "updateViewName" function has been introduced in RUM-4819
This function has been dogfooded by RUM-apps, and was proven useful.
Changes
Rename it to setViewName to match the newly introduced setViewContext / remove the experimental flag
Testing
I have gone over the contributing documentation.