🐛 allow untrusted event for httpRequest xhr event listeners

[thomas-lebeau]

Motivation

Fixes an issue where a non native XMLHttpRequest override is dispatching synthetic events (i.e. non-trusted) result in the callback not being executed, and breaking session replay ingestion.

Changes

allow untrusted event in that particular use-case. This is safe as we're not using any properties from the event.

Testing

• Local
• Staging
• Unit
• End to end

---

I have gone over the contributing documentation.

[thomas-lebeau]

/to-staging

[dd-devflow]

Devflow running: /to-staging

View all feedbacks in Devflow UI.

---

2024-11-12 12:58:39 UTC ℹ️ Branch Integration: starting soon, median merge time is 0s

Commit 5f3f019075 will soon be integrated into staging-46.

---

2024-11-12 13:11:40 UTC ℹ️ Branch Integration: This commit was successfully integrated

Commit 5f3f019075 has been merged into staging-46 in merge commit 6f3a76bc8c.

Check out the triggered pipeline on Gitlab 🦊

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.17%. Comparing base (08b2ab4) to head (9d3552e).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3123      +/-   ##
==========================================
- Coverage   93.63%   93.17%   -0.47%     
==========================================
  Files         276      276              
  Lines        7616     7615       -1     
  Branches     1709     1708       -1     
==========================================
- Hits         7131     7095      -36     
- Misses        485      520      +35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[thomas-lebeau]

dispatchEvent is normally exposed on the native xhr, so I see no reason to not expose it for mockXHR, especially as I a change the signature to be more standard.

It's just a tiny bit more verbose where dispatchEvent is called

[cit-pr-commenter]

Bundles Sizes Evolution

📦 Bundle Name	Base Size	Local Size	𝚫	𝚫%	Status
Rum	161.03 KiB	161.01 KiB	-14 B	-0.01%	✅
Logs	55.76 KiB	55.75 KiB	-12 B	-0.02%	✅
Rum Slim	109.60 KiB	109.59 KiB	-12 B	-0.01%	✅
Worker	25.21 KiB	25.21 KiB	0 B	0.00%	✅

🚀 CPU Performance

Action Name	Base Average Cpu Time (ms)	Local Average Cpu Time (ms)	𝚫
addglobalcontext	0.002	0.002	-0.000
addaction	0.049	0.054	0.004
addtiming	0.001	0.001	0.000
adderror	0.052	0.055	0.004
startstopsessionreplayrecording	1.384	1.119	-0.265
startview	1.602	1.751	0.149
logmessage	0.025	0.023	-0.003

🧠 Memory Performance

Action Name	Base Consumption Memory (bytes)	Local Consumption Memory (bytes)	𝚫 (bytes)
addglobalcontext	8.19 KiB	7.83 KiB	-372 B
addaction	40.97 KiB	39.91 KiB	-1078 B
addtiming	7.00 KiB	7.36 KiB	376 B
adderror	46.07 KiB	43.34 KiB	-2796 B
startstopsessionreplayrecording	6.40 KiB	7.05 KiB	668 B
startview	427.27 KiB	431.20 KiB	3.93 KiB
logmessage	41.12 KiB	39.91 KiB	-1229 B

🔗 RealWorld

[BenoitZugmeyer]

💬 suggestion: maybe leveraging the properties argument like ‏createNewEvent('loadend', { __ddIsTrusted: false }) could be simpler/more explicit...

[sethfowler-datadog]

Nice!