Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUM-6560] Add @session.id in Logs events #3125

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

nulrich
Copy link
Contributor

@nulrich nulrich commented Nov 12, 2024

Motivation

In Logs, we would like to migrate @session_id to @session.id like we did in RUM.

Changes

As first step, adding session.id in Logs events and keep session_id.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@nulrich nulrich requested a review from a team as a code owner November 12, 2024 16:54
Copy link
Contributor

@cy-moi cy-moi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nulrich
Copy link
Contributor Author

nulrich commented Nov 14, 2024

/to-staging

@dd-devflow
Copy link
Contributor

dd-devflow bot commented Nov 14, 2024

Devflow running: /to-staging

View all feedbacks in Devflow UI.


2024-11-14 09:24:45 UTC ℹ️ Branch Integration: starting soon, median merge time is 10m

Commit 88a978de41 will soon be integrated into staging-46.


2024-11-14 09:34:38 UTC ℹ️ Branch Integration: This commit was successfully integrated

Commit 88a978de41 has been merged into staging-46 in merge commit 96a6e35089.

Check out the triggered pipeline on Gitlab 🦊

dd-mergequeue bot added a commit that referenced this pull request Nov 14, 2024
…aging-46

Integrated commit sha: 88a978d

Co-authored-by: Nicolas Ulrich <nicolas.ulrich@datadoghq.com>
@nulrich nulrich merged commit 021a15c into main Nov 14, 2024
20 checks passed
@nulrich nulrich deleted the nicolas.ulrich/update-log-session-id-format branch November 14, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants