Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 do not include staging bump commit to changelog #3129

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

thomas-lebeau
Copy link
Collaborator

@thomas-lebeau thomas-lebeau commented Nov 13, 2024

Motivation

Every week a new staging branch is created and the CURRENT_STAGING variable is updated in gitlab.yml file. This creates a commit on the main branch that is not needed to include in the changelog as it has little value.

Changes

  • Update the generate-changlog script to skip bump staging commit messages.
  • Edit the Changelog to remove these commit to the previously released version.

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@thomas-lebeau thomas-lebeau marked this pull request as ready for review November 13, 2024 07:38
@thomas-lebeau thomas-lebeau requested a review from a team as a code owner November 13, 2024 07:38
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.05%. Comparing base (fa08217) to head (1964d60).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3129      +/-   ##
==========================================
- Coverage   93.64%   93.05%   -0.60%     
==========================================
  Files         276      276              
  Lines        7615     7615              
  Branches     1708     1708              
==========================================
- Hits         7131     7086      -45     
- Misses        484      529      +45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thomas-lebeau thomas-lebeau changed the title Thomas.lebeau/changelog no bump 👷 do not include staging bump commit to changelog Nov 13, 2024
Copy link
Contributor

@sethfowler-datadog sethfowler-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@thomas-lebeau thomas-lebeau merged commit 2c81904 into main Nov 13, 2024
19 checks passed
@thomas-lebeau thomas-lebeau deleted the thomas.lebeau/changelog-no-bump branch November 13, 2024 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants