⚗️🐛 [rum-react][RUM-6226] fix for empty splats #3142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When matching the route `/*` with the path `/`, the '*' param is an empty string (obviously). In that case, we shouldn't consider the '*' as missing and proceed with replacing the star.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3142 +/- ##
==========================================
- Coverage 93.71% 93.54% -0.17%
==========================================
Files 279 279
Lines 7682 7682
Branches 1718 1718
==========================================
- Hits 7199 7186 -13
- Misses 483 496 +13 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
amortemousque
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When the react router route
/*is matched with the/(root) path, the produced view name is/*instead of the expected/.Changes
When matching the route
/*with the path/, the*param is an empty string (obviously). In that case, we shouldn't consider the*as missing and proceed with replacing the star.Testing
I have gone over the contributing documentation.