🐛 [RUM-87] AddError should support Error instances coming from other JS contexts

[RomanGaignault]

Motivation

using DD_RUM.addError(error) but the error comes from a different context than the document (ex: created insde an iframe or a window.open), the SDK doesn not consider it as an Error instance and serializes it as JSON.

Changes

Use class object to determine if it's an error or not.

Testing

• Local
• Staging
• Unit
• End to end

---

I have gone over the contributing documentation.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.21%. Comparing base (0a018d6) to head (f228a75).
Report is 9 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3144      +/-   ##
==========================================
- Coverage   93.71%   93.21%   -0.50%     
==========================================
  Files         279      279              
  Lines        7682     7682              
  Branches     1718     1716       -2     
==========================================
- Hits         7199     7161      -38     
- Misses        483      521      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[RomanGaignault]

/to-staging

[dd-devflow]

Devflow running: /to-staging

View all feedbacks in Devflow UI.

---

2024-11-19 10:51:46 UTC ℹ️ Branch Integration: starting soon, median merge time is 0s

Commit 2f313ff0f1 will soon be integrated into staging-47.

---

2024-11-19 11:00:37 UTC ℹ️ Branch Integration: This commit was successfully integrated

Commit 2f313ff0f1 has been merged into staging-47 in merge commit c9a4836892.

Check out the triggered pipeline on Gitlab 🦊

[cit-pr-commenter]

Bundles Sizes Evolution

📦 Bundle Name	Base Size	Local Size	𝚫	𝚫%	Status
Rum	161.52 KiB	161.46 KiB	-56 B	-0.03%	✅
Logs	55.77 KiB	55.72 KiB	-56 B	-0.10%	✅
Rum Slim	110.36 KiB	110.30 KiB	-56 B	-0.05%	✅
Worker	25.21 KiB	25.21 KiB	0 B	0.00%	✅

🚀 CPU Performance

Action Name	Base Average Cpu Time (ms)	Local Average Cpu Time (ms)	𝚫
addglobalcontext	0.001	0.002	0.000
addaction	0.038	0.048	0.010
addtiming	0.001	0.001	0.000
adderror	0.034	0.036	0.002
startstopsessionreplayrecording	0.902	0.984	0.082
startview	0.986	1.098	0.112
logmessage	0.020	0.025	0.006

🧠 Memory Performance

Action Name	Base Consumption Memory (bytes)	Local Consumption Memory (bytes)	𝚫 (bytes)
addglobalcontext	6.75 KiB	7.42 KiB	684 B
addaction	38.88 KiB	39.04 KiB	160 B
addtiming	5.85 KiB	8.34 KiB	2.49 KiB
adderror	42.85 KiB	44.55 KiB	1.70 KiB
startstopsessionreplayrecording	5.70 KiB	4.43 KiB	-1299 B
startview	424.00 KiB	428.58 KiB	4.58 KiB
logmessage	40.75 KiB	40.31 KiB	-451 B

🔗 RealWorld

[amortemousque]

Should we do the same everytime we check instanceof Error?
Like in the logger:

browser-sdk/packages/logs/src/domain/logger.ts

Line 67 in f90ede4

stackTrace: error instanceof Error ? computeStackTrace(error) : undefined,

in the telemetry:

browser-sdk/packages/core/src/domain/telemetry/telemetry.ts

Line 205 in f90ede4

if (e instanceof Error) {

cc @BenoitZugmeyer

[amortemousque]

💬 suggestion: Could be nice to have a test about it.‏