Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔊[RUMF-408] add new session check logs #318

Merged
merged 5 commits into from
Mar 25, 2020

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Mar 25, 2020

Motivation

Add checks to measure new session strategy impacts on collected sessions

Changes

Introduce a _dd_exp_s cookie to store session creation date.
Put checks behind 'new-session-checks' flag.

@bcaudan bcaudan requested a review from a team as a code owner March 25, 2020 14:07
@codecov-io
Copy link

codecov-io commented Mar 25, 2020

Codecov Report

Merging #318 into master will decrease coverage by 3.79%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
- Coverage   85.72%   81.92%   -3.80%     
==========================================
  Files          25       26       +1     
  Lines        1429     1505      +76     
  Branches      302      316      +14     
==========================================
+ Hits         1225     1233       +8     
- Misses        204      272      +68     
Impacted Files Coverage Δ
packages/core/src/configuration.ts 96.55% <ø> (ø)
packages/core/src/internalMonitoring.ts 86.79% <0.00%> (-7.09%) ⬇️
packages/rum/src/newSessionChecks.ts 10.29% <10.29%> (ø)
packages/rum/src/rum.entry.ts 71.15% <50.00%> (-0.85%) ⬇️
packages/core/src/utils.ts 96.36% <100.00%> (+0.06%) ⬆️
packages/logs/src/loggerSession.ts 95.45% <0.00%> (-4.55%) ⬇️
packages/logs/src/logger.ts 94.36% <0.00%> (-1.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb56a30...cb165ec. Read the comment docs.

Copy link
Member

@BenoitZugmeyer BenoitZugmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/core/src/internalMonitoring.ts Outdated Show resolved Hide resolved
@bcaudan bcaudan merged commit a72cf71 into master Mar 25, 2020
@bcaudan bcaudan deleted the bcaudan/new-session-impact-check branch March 25, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants