Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUM-6581] Add an init parameter to chose feature flags event collection #3198

Closed
wants to merge 13 commits into from

Conversation

RomanGaignault
Copy link
Contributor

@RomanGaignault RomanGaignault commented Dec 5, 2024

Motivation

For now, feature flags are only included in views and errors. This was chosen to limit the feature flags impact on bandwidth, but now that we implemented compression, we could re-evaluate.

Changes

Instead of enabling feature flag collections on all events at once, we could provide an init parameter to allow customers to chose on which events they want to collect feature flags:
init({
collectFeatureFlagsOn: ['long_task', 'error', 'vital']
})

Testing

  • Local
  • Staging
  • Unit
  • End to end

I have gone over the contributing documentation.

@RomanGaignault RomanGaignault requested a review from a team as a code owner December 5, 2024 15:05
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.48%. Comparing base (1386574) to head (d1981c6).
Report is 311 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3198      +/-   ##
==========================================
+ Coverage   93.47%   93.48%   +0.01%     
==========================================
  Files         280      281       +1     
  Lines        7703     7721      +18     
  Branches     1727     1732       +5     
==========================================
+ Hits         7200     7218      +18     
  Misses        503      503              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cit-pr-commenter bot commented Dec 5, 2024

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 0 B 163.01 KiB 163.01 KiB N/A%
Logs 0 B 55.84 KiB 55.84 KiB N/A%
Rum Slim 0 B 111.85 KiB 111.85 KiB N/A%
Worker 0 B 25.21 KiB 25.21 KiB N/A%
🚀 CPU Performance
Action Name Base Average Cpu Time (ms) Local Average Cpu Time (ms) 𝚫
addglobalcontext N/A 0.002 0.002
addaction N/A 0.034 0.034
addtiming N/A 0.001 0.001
adderror N/A 0.033 0.033
startstopsessionreplayrecording N/A 1.064 1.064
startview N/A 0.490 0.490
logmessage N/A 0.025 0.025
🧠 Memory Performance
Action Name Base Consumption Memory (bytes) Local Consumption Memory (bytes) 𝚫 (bytes)
addglobalcontext NaN KiB 7.78 KiB NaN KiB
addaction NaN KiB 39.66 KiB NaN KiB
addtiming NaN KiB 6.70 KiB NaN KiB
adderror NaN KiB 43.82 KiB NaN KiB
startstopsessionreplayrecording NaN KiB 4.74 KiB NaN KiB
startview NaN KiB 425.83 KiB NaN KiB
logmessage NaN KiB 41.37 KiB NaN KiB

🔗 RealWorld

@RomanGaignault RomanGaignault marked this pull request as draft December 9, 2024 14:14
@RomanGaignault RomanGaignault marked this pull request as ready for review December 10, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants