✅ Add e2e test for telemetry usage #3222
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomas-lebeau
commented
Dec 17, 2024
Comment on lines
+26
to
+30
| // Force All sample rates to 100% to avoid flakiness | ||
| sessionReplaySampleRate: 100, | ||
| telemetrySampleRate: 100, | ||
| telemetryUsageSampleRate: 100, | ||
| telemetryConfigurationSampleRate: 100, |
There was a problem hiding this comment.
I think ideally we should have test that are more resilient to sample rates:
- only set them where needed (when we test a feature related to it)
- explicitly trigger an event instead of relying on telemety event:
for example, in here the logs SDK is considered started because we have a telemetry configuration event and it works because we force telemetry configuration sample rate to 100%, but that's not very explicit in the test itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Telemetry usage e2e test were missing
Changes
telemetryUsage*SampleRate: 100in the default e2e test config.Testing
I have gone over the contributing documentation.