Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️[RUMF-471] rename version #382

Merged
merged 3 commits into from
Apr 29, 2020
Merged

♻️[RUMF-471] rename version #382

merged 3 commits into from
Apr 29, 2020

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Apr 28, 2020

Why

To avoid collision with future customer version tag

Changes

  • sdk version for build env and intake tag
  • build mode for build command

Next steps

  • Recreate facet from tag on datadog app
  • Update sdk dashboard

- sdk version for build env and intake tag
- build mode for build command
@bcaudan bcaudan requested a review from a team as a code owner April 28, 2020 15:49
@codecov-io
Copy link

Codecov Report

Merging #382 into master will decrease coverage by 0.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
- Coverage   87.10%   86.81%   -0.30%     
==========================================
  Files          30       30              
  Lines        1706     1706              
  Branches      346      346              
==========================================
- Hits         1486     1481       -5     
- Misses        220      225       +5     
Impacted Files Coverage Δ
packages/core/src/init.ts 76.00% <ø> (ø)
packages/logs/src/buildEnv.ts 100.00% <ø> (ø)
packages/rum/src/buildEnv.ts 100.00% <ø> (ø)
packages/core/src/configuration.ts 97.05% <100.00%> (ø)
packages/rum/src/rum.ts 84.94% <0.00%> (-5.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e632220...e7cb6af. Read the comment docs.

Copy link
Member

@BenoitZugmeyer BenoitZugmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcaudan bcaudan merged commit 1648959 into master Apr 29, 2020
@bcaudan bcaudan deleted the bcaudan/sdk_version branch April 29, 2020 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants