👷 Removing lodash dependencies #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
thibthib
force-pushed
the
thibaut/replace-lodash
branch
2 times, most recently
from
1bf09fd to
10defdd
Compare
thibthib
force-pushed
the
thibaut/replace-lodash
branch
from
10defdd to
58e4aaa
Compare
bcaudan
reviewed
May 22, 2020
bcaudan
approved these changes
May 25, 2020
| ) | ||
| } | ||
| if (isContext(value1) && isContext(value2)) { | ||
| return Object.keys(value2).reduce( |
There was a problem hiding this comment.
A for/in loop or a (polyfilled) usage of Object.fromEntries would be easier to understand and faster here.
There was a problem hiding this comment.
It's not really clear what's polyfilled and what is not 😅 And I'm not sure ObjectEntries would be faster as it'll be doing an extra map on the array
There was a problem hiding this comment.
It's not polyfilled. It would have a lower complexity, since you recreate the whole object for each key. Anyway, a for/in could do the trick :)
glorieux
approved these changes
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The SDK code being quite large – as you can see on bundlephobia – I wanted to remove lodash as it's quite big and can easily be replaced with something smaller.
Changes
Two dependencies got replaced:
lodash.mergegot replaced with a function that does the same thing, just without the ability to merge objects with circular referenceslodash.assigngot replaced with simple loop re-assigning keysTesting
Everything should work exactly the same, but happy to write more tests if needed.
I have gone over the contributing documentation.