Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨[RUMF-473] collect view loading time in ns and integrate the load event timing in the loading time calculation #401

Merged
merged 11 commits into from
May 26, 2020
Merged

✨[RUMF-473] collect view loading time in ns and integrate the load event timing in the loading time calculation #401

merged 11 commits into from
May 26, 2020

Conversation

mquentin
Copy link
Member

@mquentin mquentin commented May 25, 2020 •
edited
Loading

Motivation

  • Sync the view loading time and UA duration units to all other collected duration
  • Make sure to have a view loading time equal to the load event when this last one occurs after the completion of all activities

Changes

  • Convert the ms duration in ns
  • compare the value of the load event and the activity completion timings and set the loading time accordingly

Testing

Create new views and check that the collected loading time is not in ms anymore

@mquentin mquentin requested a review from a team as a code owner May 25, 2020 10:08
@mquentin mquentin changed the title ✨[RUMF-473] collect view loading time and the user action duration in ns ✨[RUMF-473] collect view loading time and the user action duration in ns and use the laod event tio May 25, 2020
@mquentin mquentin changed the title ✨[RUMF-473] collect view loading time and the user action duration in ns and use the laod event tio ✨[RUMF-473] collect view loading time and the user action duration in ns and integrate the load event timing in the loading time calculation May 25, 2020
@mquentin mquentin changed the title ✨[RUMF-473] collect view loading time and the user action duration in ns and integrate the load event timing in the loading time calculation ✨[RUMF-473] collect view loading time in ns and integrate the load event timing in the loading time calculation May 25, 2020
bcaudan
bcaudan reviewed May 25, 2020
View reviewed changes
packages/rum/src/trackPageActivities.ts Outdated Show resolved Hide resolved
packages/rum/src/viewCollection.ts Outdated Show resolved Hide resolved
packages/rum/test/viewCollection.spec.ts Outdated Show resolved Hide resolved
bcaudan
bcaudan reviewed May 26, 2020
View reviewed changes
packages/rum/test/viewCollection.spec.ts
domComplete: 2,
domContentLoadedEventEnd: 1,
domInteractive: 1,
entryType: 'navigation',
loadEventEnd: 1,
loadEventEnd: BEFORE_PAGE_ACTIVITY_VALIDATION_DELAY * 0.8,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@mquentin mquentin merged commit 00d13f5 into master May 26, 2020
@mquentin mquentin deleted the maxime.quentin/ConvertViewLoadingTimeInNs branch May 26, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenoitZugmeyer BenoitZugmeyer BenoitZugmeyer left review comments

@bcaudan bcaudan bcaudan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mquentin @BenoitZugmeyer @bcaudan