Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨[RUMF-603] Introduce and use new lifecycle events #438

Merged
merged 5 commits into from
Jul 2, 2020
Merged

✨[RUMF-603] Introduce and use new lifecycle events #438

merged 5 commits into from
Jul 2, 2020

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Jul 2, 2020

Motivation

Prepare future work on associate events with its parents based on start time
Fix discard user action on view created instead of view update

Changes

Introduce new events:

  • VIEW_CREATED: when a view is created
  • VIEW_UPDATED: when a view is updated
  • ACTION_CREATED: when an action is created
  • ACTION_COMPLETED: when an action is completed
  • ACTION_DISCARDED: when an action is discarded

Testing

automated tests

I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner July 2, 2020 09:30
BenoitZugmeyer
BenoitZugmeyer reviewed Jul 2, 2020
View reviewed changes
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first step :)

packages/rum/test/viewCollection.spec.ts Outdated Show resolved Hide resolved
packages/rum/src/userActionCollection.ts Show resolved Hide resolved
@bcaudan bcaudan force-pushed the bcaudan/new-lifecycle branch from 7e58904 to 8888914 Compare July 2, 2020 13:29
BenoitZugmeyer
BenoitZugmeyer approved these changes Jul 2, 2020
View reviewed changes
Copy link
Member

@BenoitZugmeyer BenoitZugmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , just one callback could be converted to a spy

packages/rum/test/viewCollection.spec.ts Outdated Show resolved Hide resolved
@bcaudan bcaudan merged commit 50e67b5 into master Jul 2, 2020
@bcaudan bcaudan deleted the bcaudan/new-lifecycle branch July 2, 2020 13:59
@bcaudan bcaudan mentioned this pull request Jul 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenoitZugmeyer BenoitZugmeyer BenoitZugmeyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bcaudan @BenoitZugmeyer