Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUMF-605] enable event association to parent context by start date #460

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Jul 21, 2020

Motivation

cf ✨ associate event to parent context by start date (behind flag)

Changes

Remove flag

Testing

Automated tests


I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner July 21, 2020 13:32
@bcaudan bcaudan force-pushed the bcaudan/remove-flag branch from a130fd4 to 4555b41 Compare July 21, 2020 13:35
@codecov-commenter
Copy link

Codecov Report

Merging #460 into master will decrease coverage by 0.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #460      +/-   ##
==========================================
- Coverage   87.68%   87.32%   -0.36%     
==========================================
  Files          32       32              
  Lines        2022     2020       -2     
  Branches      410      409       -1     
==========================================
- Hits         1773     1764       -9     
- Misses        249      256       +7     
Impacted Files Coverage Δ
packages/rum/src/parentContexts.ts 98.14% <100.00%> (-0.07%) ⬇️
packages/rum/src/rum.ts 86.77% <100.00%> (-4.14%) ⬇️
packages/core/src/configuration.ts 84.44% <0.00%> (-4.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b25ae0...4555b41. Read the comment docs.

Copy link
Member

@mquentin mquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@bcaudan bcaudan merged commit df7a583 into master Jul 22, 2020
@bcaudan bcaudan deleted the bcaudan/remove-flag branch July 22, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants