SDK: better support for SPA routing - STEP 1/2 : add hash tracking #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcaudan
suggested changes
Jul 22, 2020
|
This PR should not be merged on master while anchor hash are not excluded, right? |
mquentin
changed the title
mquentin
changed the base branch from
master
to
maxime.quentin/betterSupportForSPArouting
Codecov Report
@@ Coverage Diff @@
## maxime.quentin/betterSupportForSPArouting #463 +/- ##
=============================================================================
- Coverage 87.93% 87.51% -0.43%
=============================================================================
Files 32 32
Lines 2022 2026 +4
Branches 410 411 +1
=============================================================================
- Hits 1778 1773 -5
- Misses 244 253 +9
Continue to review full report at Codecov.
|
bcaudan
reviewed
Jul 28, 2020
bcaudan
reviewed
Jul 28, 2020
bcaudan
approved these changes
Jul 28, 2020
mquentin
deleted the
maxime.quentin/betterSupportForSPAroutingAddhashTracking
branch
bcaudan
added a commit
that referenced
this pull request
Aug 4, 2020
* SDK: better support for SPA routing - STEP 1/2 : add hash tracking (#463) * add hash tracking * ✅ add hash change tests * introduce renewViewOnChange * add better management and comments of the areViewDifferent hash part * set async tests for hashchanges * reset window.location.hash of previous tests * skip tesst using Promise for IE * replace jasmine promise with callback process * remove anchor check on this PR * ✅ and implem reviews * SDK: better support for SPA routing - STEP 2/2 : filter out html anchor tags changes (#466) * add hash tracking * ✅ add hash change tests * introduce renewViewOnChange * add better management and comments of the areViewDifferent hash part * set async tests for hashchanges * reset window.location.hash of previous tests * skip tesst using Promise for IE * replace jasmine promise with callback process * remove anchor check on this PR * add anchor nav filter * patch tslint error * ✅ and implem reviews * implement reviews regarding func naming and hash cleaning * simplify mockGetElementById * add e2e tests * simply anchor filter out proccess * implement reviews * unit test the hash change acknowledgement after an anchor nav * fix typo * fix typo v2 * fix mock hash Co-authored-by: Bastien Caudan <bastien.caudan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Given
startViewCollection
When
on window.location.hash changes
Then
check if the views are different.
If the hash fragment has changed, then the views are different.
Changes
trackHashfunctionareDifferentViewsto handle hash changesTesting
✅ hash changes tests have been added both for pushStates and window.location.hash window.location.hash
Test with the Vue router without
mode: 'history':const router = new VueRouter({ routes })SHOULD NOT BE MERGE UNTIL STEP 2 is done
SDK: better support for SPA routing - STEP 2/2 : filter out html anchor tags changes