[RUMF-625] make sure view url doesn't change #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes withFakeLocation simpler to use: pass a base URL (or path) and the whole location will be built automatically. Also, it allows the test to change the fake location by using the history api.
bcaudan
reviewed
Jul 31, 2020
packages/rum/src/rum.ts
Outdated
| @@ -359,6 +360,7 @@ function trackView(lifeCycle: LifeCycle, handler: (startTime: number, event: Rum | |||
| loadingTime: view.loadingTime ? msToNs(view.loadingTime) : undefined, | |||
| loadingType: view.loadingType, | |||
| measures: view.measures, | |||
| url: view.location.href, | |||
There was a problem hiding this comment.
With this approach, url from ViewContext is still wrong so it can still be wrongly associated to other event types.
What about fixing it there?
There was a problem hiding this comment.
I wrote a new fix, let me know if it looks right :)
Codecov Report
@@ Coverage Diff @@
## master #469 +/- ##
==========================================
+ Coverage 87.57% 87.60% +0.03%
==========================================
Files 32 32
Lines 2020 2025 +5
Branches 409 409
==========================================
+ Hits 1769 1774 +5
Misses 251 251
Continue to review full report at Codecov.
|
bcaudan
reviewed
Jul 31, 2020
bcaudan
reviewed
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When a SPA changes its URL, the ending view gets updated with the new URL. It should keep its initial URL no matter what.
See https://datadoghq.atlassian.net/browse/RUMF-625
Changes
When formating a RumViewEvent, use the one from the collected View object instead of the ViewContext which already contains the new URL
Testing
I have gone over the contributing documentation.