🐛[RUMF-617] fix missing headers on traced requests #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some requests headers possible types were not copied with the tracing headers, resulting in some request failures due to missing headers.
Codecov Report
@@ Coverage Diff @@
## master #517 +/- ##
==========================================
- Coverage 87.86% 87.80% -0.06%
==========================================
Files 36 36
Lines 2233 2239 +6
Branches 453 455 +2
==========================================
+ Hits 1962 1966 +4
- Misses 271 273 +2
Continue to review full report at Codecov.
|
BenoitZugmeyer
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
some requests headers possible types were not copied with the tracing headers, resulting in some request failures due to missing headers.
Changes
Handle other headers types
Testing
Automated tests
I have gone over the contributing documentation.