Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [RUMF-648] add cookie configuration options #523

Merged
merged 4 commits into from
Sep 9, 2020

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Sep 8, 2020

Motivation

Multiple customer requests on cookie configuration options

Changes

Add configuration options:

  • trackSessionAcrossSubdomains: preserve session across subdomains of the same site
  • enforceSecureContextExecution: use a secure session cookie
  • allowThirdPartyContextExecution: use a secure cross-site session cookie

Testing

Automated tests for configuration to cookie
Manual test on www.saopolo.sp.gov.br for getCurrentSite


I have gone over the contributing documentation.

@bcaudan bcaudan force-pushed the bcaudan/cookie-config branch from b19a4ca to a7c53ef Compare September 8, 2020 13:48
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2020

Codecov Report

Merging #523 into master will decrease coverage by 0.02%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #523      +/-   ##
==========================================
- Coverage   88.08%   88.06%   -0.03%     
==========================================
  Files          36       36              
  Lines        2241     2262      +21     
  Branches      457      466       +9     
==========================================
+ Hits         1974     1992      +18     
- Misses        267      270       +3     
Impacted Files Coverage Δ
packages/core/src/cookie.ts 89.58% <90.00%> (-2.09%) ⬇️
packages/core/src/configuration.ts 83.87% <100.00%> (+1.72%) ⬆️
packages/core/src/init.ts 80.00% <100.00%> (ø)
packages/core/src/sessionManagement.ts 100.00% <100.00%> (ø)
packages/logs/src/loggerSession.ts 95.65% <100.00%> (ø)
packages/logs/src/logs.entry.ts 50.76% <100.00%> (ø)
packages/rum/src/rum.entry.ts 76.92% <100.00%> (+1.11%) ⬆️
packages/rum/src/rumSession.ts 100.00% <100.00%> (ø)
packages/rum/src/rum.ts 90.37% <0.00%> (-0.75%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a81c2b7...a168c27. Read the comment docs.

@bcaudan bcaudan force-pushed the bcaudan/cookie-config branch from a7c53ef to 9dd7ed5 Compare September 8, 2020 14:11
@bcaudan bcaudan marked this pull request as ready for review September 8, 2020 14:22
@bcaudan bcaudan requested a review from a team as a code owner September 8, 2020 14:22
packages/logs/README.md Outdated Show resolved Hide resolved
packages/logs/test/logs.entry.spec.ts Outdated Show resolved Hide resolved
@bcaudan bcaudan merged commit d169349 into master Sep 9, 2020
@bcaudan bcaudan deleted the bcaudan/cookie-config branch September 9, 2020 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants