Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix issue when using proxy #530

Merged
merged 1 commit into from
Sep 11, 2020
Merged

🐛 fix issue when using proxy #530

merged 1 commit into from
Sep 11, 2020

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Sep 11, 2020 •
edited
Loading

Motivation

fix #529

Changes

Remove useless buggy check and add missing unit tests

Testing

Automated tests

I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner September 11, 2020 09:19
mquentin
mquentin approved these changes Sep 11, 2020
View reviewed changes
Copy link
Member

@mquentin mquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcaudan bcaudan merged commit 33d0d5e into master Sep 11, 2020
@bcaudan bcaudan deleted the bcaudan/proxy-error branch September 11, 2020 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mquentin mquentin mquentin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URL constructor error while using proxy host
2 participants
@bcaudan @mquentin