-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the same options to test and set cookies #555
Conversation
Current code only uses some of the configured flags to set test cookies. This leads to cases where testing for cookies can fail even though setting cookies would eventually work.
Hi @kichik, Thanks for this PR, it is conflicting with some in progress work so we will try to integrate it in the coming days. |
Also, adjust core exports
Codecov Report
@@ Coverage Diff @@
## master #555 +/- ##
==========================================
- Coverage 88.45% 88.42% -0.03%
==========================================
Files 42 42
Lines 2296 2299 +3
Branches 479 479
==========================================
+ Hits 2031 2033 +2
- Misses 265 266 +1
Continue to review full report at Codecov.
|
Thanks! Any idea when 1.23.0 might be available on npm? |
@kichik Thank you for your contribution! v1.23.0 has been published, and should be available on NPM right now. |
Current code only uses some of the configured flags to set test cookies. This leads to cases where testing for cookies can fail even though setting cookies would eventually work.
Motivation
Using RUM inside
<iframe>
didn't work, even though all the documented flags required for it were enabled.Changes
areCookiesAuthorized()
usesCookieOptions
instead of just{ secure: useSecureCookie }
.Testing
Use RUM in
<iframe>
that's on a different domain than the main page.I have gone over the contributing documentation.