✨ [RUMF-762] include the context when using console handler #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
webNeat
changed the title
bcaudan
reviewed
Nov 10, 2020
|
Thanks for doing this! I was hunting through the repo looking for exactly this feature; glad to see it's already done! Do you know when the next npm release will be cut so I can get my hands on the new functionality? |
|
@trestletech, it has been released in v1.25.4 |
This was referenced Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixing #589
Changes
The context is now included when using the
consolehandler. It's passed as the second parameter toconsole.logcall instead of calling it twice.Testing
I updated the logs unit tests to check that the context is included.
I have gone over the contributing documentation.