✨ [RUMF-771] Add getLoggerGlobalContext and getRumGlobalContext #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webNeat
force-pushed
the
amine/add-global-context-getter
branch
from
0164d6f to
6d4812f
Compare
Codecov Report
@@ Coverage Diff @@
## master #614 +/- ##
==========================================
- Coverage 89.09% 88.85% -0.24%
==========================================
Files 54 54
Lines 2503 2503
Branches 541 541
==========================================
- Hits 2230 2224 -6
- Misses 273 279 +6
Continue to review full report at Codecov.
|
3 tasks
bcaudan
approved these changes
Nov 13, 2020
| @@ -29,7 +29,7 @@ export function startLoggerSession(configuration: Configuration, areCookieAuthor | |||
| } | |||
| } | |||
|
|
|||
| function computeTrackingType(configuration: Configuration): string { | |||
| function computeTrackingType(configuration: Configuration): LoggerTrackingType { | |||
There was a problem hiding this comment.
Suggested change
| function computeTrackingType(configuration: Configuration): LoggerTrackingType { | |
| function computeTrackingType(configuration: Configuration) { |
the compiler should figure it out, explicit typing does not seem necessary here
This was referenced Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Simply debugging by providing getters for global contexts.
Changes
getLoggerGlobalContextandgetRumGlobalContextTesting
No new tests were added since the contextManager methods are already tested and those getters are just aliases of
contextManager.get.I have gone over the contributing documentation.