-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [RUMF-775] implement Largest Contentful Paint #624
Conversation
1ab26c1
to
b43b54b
Compare
Codecov Report
@@ Coverage Diff @@
## master #624 +/- ##
==========================================
+ Coverage 88.23% 88.25% +0.02%
==========================================
Files 56 56
Lines 2525 2538 +13
Branches 546 547 +1
==========================================
+ Hits 2228 2240 +12
- Misses 297 298 +1
Continue to review full report at Codecov.
|
packages/rum/src/domain/rumEventsCollection/view/trackTimings.spec.ts
Outdated
Show resolved
Hide resolved
packages/rum/src/domain/rumEventsCollection/view/trackTimings.ts
Outdated
Show resolved
Hide resolved
) { | ||
const firstHidden = trackFirstHidden() | ||
|
||
// Ignore entries that come after the first user interaction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it could be helpful to add a link to the spec of these new timings or maybe describe the different rules in a function comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find a link to show that it is needed. All the documentation (here, spec draft readme, spec draft ) seems to agree that the browser won't send those performance entries after the first user interaction. I think that's just a safeguard that web-vitals implemented because of some Chrome issues.
Motivation
Expose the web-vitals LCP on initial views
Changes
Testing
CI + manual tests on chrome
I have gone over the contributing documentation.