Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RUMF-807] Broaden context types in APIs #663

Merged
merged 2 commits into from
Dec 29, 2020
Merged

Conversation

bcaudan
Copy link
Contributor

@bcaudan bcaudan commented Dec 22, 2020

Motivation

Using Context or ContextValue in our APIs is not convenient for typescript customers since customer interfaces won't be compatible with them due to index signature missing on interfaces.

Changes

Replace Context by object and ContextValue by any in APIs
Keep using Context and ContextValue internally.

fix #603

Testing


I have gone over the contributing documentation.

@bcaudan bcaudan requested a review from a team as a code owner December 22, 2020 10:54
@codecov-io
Copy link

Codecov Report

Merging #663 (f843141) into master (c645bf8) will increase coverage by 0.15%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #663      +/-   ##
==========================================
+ Coverage   87.59%   87.75%   +0.15%     
==========================================
  Files          55       55              
  Lines        2531     2531              
  Branches      524      524              
==========================================
+ Hits         2217     2221       +4     
+ Misses        314      310       -4     
Impacted Files Coverage Δ
packages/logs/src/boot/logs.entry.ts 100.00% <ø> (ø)
packages/rum/src/boot/rum.entry.ts 93.90% <50.00%> (ø)
packages/core/src/tools/contextManager.ts 100.00% <100.00%> (ø)
packages/logs/src/domain/logger.ts 95.23% <100.00%> (ø)
packages/rum/src/transport/batch.ts 78.94% <0.00%> (+10.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c645bf8...f843141. Read the comment docs.

@BenoitZugmeyer BenoitZugmeyer merged commit 9996caf into master Dec 29, 2020
@BenoitZugmeyer BenoitZugmeyer deleted the bcaudan/context branch December 29, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type ContextValue does not have object on its type
4 participants