✨ Implement addTiming #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcaudan
reviewed
Jan 5, 2021
packages/rum/src/domain/rumEventsCollection/view/viewCollection.ts
Outdated
Show resolved
Hide resolved
packages/rum/src/domain/rumEventsCollection/view/viewCollection.ts
Outdated
Show resolved
Hide resolved
packages/rum/src/domain/rumEventsCollection/view/viewCollection.ts
Outdated
Show resolved
Hide resolved
packages/rum/src/domain/rumEventsCollection/view/trackViews.spec.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #668 +/- ##
==========================================
- Coverage 77.86% 77.81% -0.05%
==========================================
Files 60 60
Lines 3266 3282 +16
Branches 710 714 +4
==========================================
+ Hits 2543 2554 +11
- Misses 723 728 +5
Continue to review full report at Codecov.
|
webNeat
force-pushed
the
amine/add-timing
branch
from
e818288 to
7d2c641
Compare
webNeat
force-pushed
the
amine/add-timing
branch
from
acfcf89 to
5016c63
Compare
bcaudan
reviewed
Jan 6, 2021
packages/rum/src/domain/rumEventsCollection/view/viewCollection.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Bastien Caudan <bastien.caudan@datadoghq.com>
bcaudan
reviewed
Jan 8, 2021
packages/rum-core/src/domain/rumEventsCollection/view/viewCollection.spec.ts
Outdated
Show resolved
Hide resolved
packages/rum-core/src/domain/rumEventsCollection/view/viewCollection.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Bastien Caudan <bastien.caudan@datadoghq.com>
Co-authored-by: Bastien Caudan <bastien.caudan@datadoghq.com>
webNeat
force-pushed
the
amine/add-timing
branch
from
7a2ca0b to
2ee6e03
Compare
bcaudan
reviewed
Jan 11, 2021
| addTiming: () => undefined, | ||
| configuration: ({ | ||
| isEnabled: () => false, | ||
| } as any) as Configuration, |
There was a problem hiding this comment.
cf previous comment, any could be removed here too
| const view = { | ||
| location, |
There was a problem hiding this comment.
Suggested change
| location, | |
| location: location as Location, |
it would remove the need to cast view as View in the next statement
packages/rum/src/rumEvent.types.ts
Outdated
| @@ -0,0 +1,658 @@ | |||
| /* tslint:disable */ | |||
There was a problem hiding this comment.
cf c822e93, it is not the right file
packages/rum-core/test/fixtures.ts
Outdated
| @@ -66,6 +66,7 @@ export function createRawRumEvent(type: RumEventType, overrides?: Context): RawR | |||
| date: 0, | |||
| view: { | |||
| action: { count: 0 }, | |||
| customTimings: {}, | |||
bcaudan
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add
DD_RUM.addTiming()API.Changes
Added the method
addTimingto the global RUM objectnameis the name of the custom timing. If the view already has that timing, it will be updated with the giventime.inInitialViewindicates if we want to add the timing in the initial view. Otherwise the timing is added to the current view.This new method is hidden behind the feature flag
custom-timings.Testing
I have gone over the contributing documentation.